Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(device_info_plus): Add Android display metrics check, fix Android version check #1242

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

After adding an Android build matrix saw that integration tests fail for device_info_plus on newly added Andoid APIs. As it turned out there was a hardcoded version of Android (30), which caused test to fail on all other versions.
Also, saw that same test was missing check for a newly added device metrics data, so added it as well.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nohli
Copy link
Member

nohli commented Oct 15, 2022

Is it somewhere in our docs that they return null on lower versions?

@vbuberen
Copy link
Collaborator Author

Is it somewhere in our docs that they return null on lower versions?

No. we don't have it. I will create a separate PR as I see one more possible improvement for our docs on the website for this plugin.

@vbuberen vbuberen merged commit e23ad71 into main Oct 15, 2022
@vbuberen vbuberen deleted the fix/device_info_test branch October 15, 2022 18:42
@nohli
Copy link
Member

nohli commented Oct 15, 2022

If even we don't really know, we should put it in the docs of the methods that return null for specific versions.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants