Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(device_info_plus): Add info about Android properties availability, update API docs links #1243

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

Adding more info to some of AndroidDeviceInfo properties, so it is clear which properties might be null on some older platforms.

Saw that links to API documentation on the website and README redirected users just to pub.dev page of the device_info_plus, so updated the link. Also added the same link to the Overview page explaining to users that they can find the full list of properties there.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added documentation Improvements or additions to documentation device_info_plus labels Oct 15, 2022
@github-actions
Copy link

github-actions bot commented Oct 15, 2022

Visit the preview URL for this PR (updated for commit 7640ba8):

https://flutter-community-plus--pr1243-update-docs-device-i-rm62s3ff.web.app

(expires Sat, 29 Oct 2022 20:00:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93639d72b8f1760454794920b64e5b0c0801b3ef

Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vbuberen vbuberen merged commit efc72dc into main Oct 15, 2022
@vbuberen vbuberen deleted the update/docs_device_info branch October 15, 2022 20:31
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device_info_plus documentation Improvements or additions to documentation Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants