Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(device_info_plus): Migrate Android part to Kotlin, update Android dependencies #1245

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

Continuing the series of PR to migrate Android parts of plugins to Kotlin. Functionality stays the same, nothing breaking is expected. Also bumped Kotlin and Gradle versions for both plugin and example app.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

val featureInfos: Array<FeatureInfo> = packageManager.systemAvailableFeatures
return featureInfos
.filterNot { featureInfo -> featureInfo.name == null }
.map { featureInfo -> featureInfo.name }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am filtering the output because on emulator saw element with name null.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 17, 2022
@vbuberen vbuberen merged commit a6e93ac into main Oct 17, 2022
@vbuberen vbuberen deleted the refactor/device_info_kotlin branch October 17, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants