Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(device_info_plus)!: Change nullability for AndroidDeviceInfo properties #1246

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

It seems that during migration to null safety all properties for Android platform were just marked as nullable, while in reality almost all properties are not nullable. Thus, we had issues like #706 with users not really understanding why something is nullable now.

I refactored the plugin interface to have only a few properties which really can be null declared as nullable, while the rest if non-nullable anymore.

Related Issues

#706

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen requested review from miquelbeltran, Schwusch and nohli and removed request for Schwusch October 16, 2022 12:35
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 17, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants