-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share_plus): share XFile created using File.fromData() #1284
feat(share_plus): share XFile created using File.fromData() #1284
Conversation
…romData() if file doesn't contain path then make new file in TemporaryDirectory and return with path
melos run format gives this error Unable to run "clang-format". Make sure that it is in your path, or provide a full path with --clang-format. |
one of test is failing as sharing empty file no longer throws assertion error |
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
Tentative looking good for me, I need to try this on my PC in the coming days tho. But, in order to approve a merge, you will need to provide a unit test or integration test at least showing this (e.g. call to shareXFile with a file created using fromData) and all failing tests should be fixed (or removed if no longer relevant) |
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This works great!
Let's wait for the integration tests to finish, and we can merge |
Seems that emulator with API 32 not having a day today, but the other API levels passed and the error is unrelated, so giving it a go |
Description
in shareXfile if sharedFile doesn't contain path
then make new file in TemporaryDirectory and return with path
Related Issues
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
not sure about this.
!
in the title as explained in Conventional Commits).