Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package_info_plus): Make installerStore an optional argument in mocks #1547

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

ChristianEdwardPadilla
Copy link
Contributor

Making this a required argument unnecessarily broke all calls to setMockInitialValues. This undoes that change but is not itself a breaking change.

Description

Make installerStore an optional argument in setMockInitialValues.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

…king

Making this a required argument unnecessarily broke all calls to setMockInitialValues. This undoes that change but is not itself a breaking change.
@ChristianEdwardPadilla ChristianEdwardPadilla changed the title [package_info_plus] Make installerStore an optional argument in mocks fix(package_info_plus): Make installerStore an optional argument in mocks Feb 14, 2023
Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohli nohli merged commit dc8d56f into fluttercommunity:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants