Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(all): Fix macos integration tests for all packages #1597

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Mar 4, 2023

Description

After some research found out that MacOS integration tests were failing due to this issue flutter/flutter#118469
Older Flutter version is suggested as a solution for this problem. I have tested the change in #1596 and saw that it works. Thus, updated all workflows to use older Flutter version and explanation comment on why fixed version is used.

Fixes #1591

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added CI/CD Everything related to automated builds and deployments e2e tests Issue with e2e tests github_actions Pull requests that update GitHub Actions code labels Mar 4, 2023
Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Copy link
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vbuberen vbuberen merged commit c97158c into main Mar 5, 2023
@vbuberen vbuberen deleted the fix/macos_tests branch March 5, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Everything related to automated builds and deployments e2e tests Issue with e2e tests github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]: integration tests are timing out on macOS
3 participants