Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package_info_plus): Make example app content scrollable #1614

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

vbuberen
Copy link
Collaborator

Description

While testing some changes for package_info_plus saw that example app has non-scrollable content, so in landscape mode there is an overflow (see attached screenshot). This PR fixes it along with switching example app to usage of Material 3. Used the same color seed as in share_plus. The only addition is an elevation to AppBar, so it is not white by default. Did the same adjustment to share_plus for consistency.

Before:
photo_2023-03-11 22 01 13
After:
photo_2023-03-11 22 01 16

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added the package_info_plus stuff related to package_info_plus label Mar 11, 2023
Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vbuberen vbuberen merged commit 926f617 into main Mar 17, 2023
@vbuberen vbuberen deleted the fix/package_info_example branch March 17, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package_info_plus stuff related to package_info_plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants