-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(all): Remove all manual dependency_overrides #1628
refactor(all): Remove all manual dependency_overrides #1628
Conversation
Unfortunately it doesn't solve the problem I mentioned in #1619 (comment) because it is not about using overrides, but because I have tried your PR with additional similar change in |
Makes sense that it didn't solve anything then.
You still have to run Melos bootstrap to work locally though, and then it would set up the examples to be dependent on the other packages in the repository? |
No, I don't. I started to use Melos only recently and only for purpose of publishing. Before that just opened a project of a plugin in question and work on it. |
Interesting, how do you work with changing packages that are dependent on other packages in the repository, like the interfaces for example? Because if you haven't run melos bootstrap it would pull the interface package from pub instead of using the local one? |
Probably, I haven't bumped into this case so far 🤷🏻 |
@vbuberen should I close this or do you want to start using melos all the way? :) |
Well, let's merge it if Melos takes care of this stuff during versioning, but don't really see much benefits. |
Head branch was pushed to by a user without write access
9ac1213
to
0a850fc
Compare
0a850fc
to
23a1b70
Compare
@vbuberen something strange had happened when this branch was updated with main, but it's fixed now. The auto-complete was cancelled though. |
Yeah, had to manually restart some of our flaky android integration tests, but now everything seems fine. |
Description
Manual dependency_overrides in the examples shouldn't be needed since Melos already should handle those.
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?