-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(device_info_plus): add major, minor and patch versions to macos #1649
Conversation
Android build is failing, but doesn't seem related? |
Thanks for your contribution. I would also ask you to add these new fields to the
Yes, correct. Android tests are flaky here. But seems like re-run helped. |
Should we also return a String with all, like version: 13.1.0? |
I thin that's something the user can easily concatenate on their side. It's the same with windows info, there are 3 separate fields. |
packages/device_info_plus/device_info_plus/macos/Classes/DeviceInfoPlusMacosPlugin.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thakns @nohli I couldn't find any info on the release process. How often does the package get released to pub.dev? |
Right now, there is a bug in our publishing tool, but vbueren will try to publish later today. |
Description
This PR adds major/minor/patch versions to mac info class, similar to what's available on windows.
With this fields we don't need to parse the version from of the osRelease field (which apple doesn't recommend).
https://developer.apple.com/documentation/foundation/operatingsystemversion
Checklist
CHANGELOG.md
nor thepubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).