Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(device_info_plus): add major, minor and patch versions to macos #1649

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

goenning
Copy link
Contributor

Description

This PR adds major/minor/patch versions to mac info class, similar to what's available on windows.

With this fields we don't need to parse the version from of the osRelease field (which apple doesn't recommend).

https://developer.apple.com/documentation/foundation/operatingsystemversion

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@goenning goenning changed the title add major, minor and patch versions to macos feat(device_info_plus): add major, minor and patch versions to macos Mar 28, 2023
@goenning
Copy link
Contributor Author

Android build is failing, but doesn't seem related?

@vbuberen
Copy link
Collaborator

vbuberen commented Apr 4, 2023

Thanks for your contribution.

I would also ask you to add these new fields to the example app, so they will be visible as well near that osRelease string.

Android build is failing, but doesn't seem related?

Yes, correct. Android tests are flaky here. But seems like re-run helped.

@goenning
Copy link
Contributor Author

goenning commented Apr 4, 2023

Done! :)
Screenshot 2023-04-04 at 22 05 00

@nohli
Copy link
Member

nohli commented Apr 5, 2023

Should we also return a String with all, like version: 13.1.0?

@goenning
Copy link
Contributor Author

goenning commented Apr 5, 2023

I thin that's something the user can easily concatenate on their side. It's the same with windows info, there are 3 separate fields.

Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nohli nohli merged commit e871e1b into fluttercommunity:main Apr 5, 2023
@goenning
Copy link
Contributor Author

goenning commented Apr 5, 2023

Thakns @nohli I couldn't find any info on the release process. How often does the package get released to pub.dev?

@nohli
Copy link
Member

nohli commented Apr 5, 2023

Right now, there is a bug in our publishing tool, but vbueren will try to publish later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants