Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): Add pub.dev topics #3097

Merged
merged 2 commits into from
Jul 23, 2024
Merged

chore(all): Add pub.dev topics #3097

merged 2 commits into from
Jul 23, 2024

Conversation

vbuberen
Copy link
Collaborator

Description

Picked some of available topics from https://dart.dev/tools/pub/pubspec#topics and added for every plugin.
Feel free to add some if I missed something or there are some better topics.

Related Issues

Closes #2941

Copy link
Contributor

@aanas-sayed aanas-sayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I'd have a look and had a few points I wanted to raise. Thank you!

@@ -4,6 +4,10 @@ version: 5.0.2
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/android_intent_plus
issue_tracker: https://github.com/fluttercommunity/plus_plugins/labels/android_intent_plus
topics:
- android
- intent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topic for intents already exists which could be used as intent does not exist.
https://pub.dev/topics

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done on purpose. Android has Intent mechanism, so I want to be specific that it is about it and not some generic intents.

@@ -5,6 +5,9 @@ version: 4.0.3
homepage: https://plus.fluttercommunity.dev/
repository: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/android_alarm_manager_plus
issue_tracker: https://github.com/fluttercommunity/plus_plugins/labels/android_alarm_manager_plus
topics:
- android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I noticed for some of these have android topic added, but then missing the platform information from others. Do you think it worth adding topics for every platform? There is the 5 topic limitation so I was thinking maybe either the specific platform like in this case android or in other cases cross-platform. What do you think?
  2. Perhaps native could be added to this and most of the other packages as they include native code for each platform? Its the only other topic I can see being related to this project from existing topics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just android is fine in this case, since it is an android-only package. Same with android_intent_plus.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed for some of these have android topic added, but then missing the platform information from others. Do you think it worth adding topics for every platform? There is the 5 topic limitation so I was thinking maybe either the specific platform like in this case android or in other cases cross-platform. What do you think?

No, it makes no sense and is an equivalent to tons of hashtags in socials. There is already info on pub.dev about supported platforms. android here is to just highlight that 2 packages are specifically about some Android functionality.

Perhaps native could be added to this and most of the other packages as they include native code for each platform? Its the only other topic I can see being related to this project from existing topics.

Same as previously - I don't want to turn this section into a set of hashtags just because.

Comment on lines +8 to +10
topics:
- device
- information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other packages have utils topic but not this (and android alarm manager plus). Should this be added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, missed that one. Thanks.

Comment on lines +8 to +10
topics:
- android
- alarm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other packages have utils topic but not this (and device info plus). Should this be added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, missed it. Thanks.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I 👍 some of the suggestions by @aanas-sayed as well.

@vbuberen vbuberen merged commit c1c0698 into main Jul 23, 2024
110 of 117 checks passed
@vbuberen vbuberen deleted the chore/tags branch July 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Consider adding topics to pubspec.yaml for better discoverability
3 participants