Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AGP 8.0 Support: Compile share_plus wth JavaVersion.VERSION_1_8 #3245

Closed
wants to merge 1 commit into from

Conversation

francis94c
Copy link

Description

This PR ensures that the share_plus plugin will now compile with JDK 1.8 on the android side

Related Issues

  • None.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@francis94c francis94c changed the title AGP 8.0 Support: Compile share_plus wth JavaVersion.VERSION_1_8 refactor: AGP 8.0 Support: Compile share_plus wth JavaVersion.VERSION_1_8 Sep 7, 2024
@vbuberen
Copy link
Collaborator

Plugins won't move to Java 8.

Closing as invalid.

@vbuberen vbuberen closed this Sep 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants