-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network_info_plus): add ipv6, gateway, broadcast and subnet mask information #355
feat(network_info_plus): add ipv6, gateway, broadcast and subnet mask information #355
Conversation
…rence/plus_plugins into feature/network_more_info
Looks like there are some issues with formating. |
I have reviewed this code and LGTM. thank you for your PR. I feel this is a great addition to network_info plus. @jpnurmi @miquelbeltran any comment or concerns? |
changes look good to me! the formatting needs to be fixed, yes |
Hi, we can't get Unhandled exception:
ProcessException: No such file or directory
# [...]
#0 _ProcessImpl._start (dart:io-patch/process_patch.dart:390:33)
#1 Process.start (dart:io-patch/process_patch.dart:36:20)
#2 ProcessRunner.runAndStream (package:flutter_plugin_tools/src/common/process_runner.dart:37:49)
#3 FormatCommand._formatCppAndObjectiveC (package:flutter_plugin_tools/src/format_command.dart:108:27)
<asynchronous suspension>
#4 FormatCommand.run (package:flutter_plugin_tools/src/format_command.dart:48:5)
<asynchronous suspension>
#5 CommandRunner.runCommand (package:args/command_runner.dart:196:13)
<asynchronous suspension>
#6 main.<anonymous closure> (package:flutter_plugin_tools/src/main.dart)
<asynchronous suspension> Do you had some clues @mhadaily @miquelbeltran ? |
@dim-apparence It looks like you don't have |
…rence/plus_plugins into feature/network_more_info
Thanks @stuartmorgan, |
@v-apparence this is great so far. There is one thing that our code coverage deceased a bit I can see why it happens though. @miquelbeltran @jpnurmi any comment, if not, let's merge and publish this |
@miquelbeltran @jpnurmi I am going to merge this PR, even though it has lower test coverage, do you have any objection to this? |
@mhadaily yes, let's go for it! |
#ifndef getgateway_h | ||
#define getgateway_h | ||
|
||
int getDefaultGateway(in_addr_t* addr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this type coming from?
Description
We added for both iOS and Android support for fetching information :
Linux, MacOS and Windows was not done in this PR and need help 👍
Related Issues
#206
#132
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?