Fix drag and drop bug on non-Windows platforms #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the drag and drop only works on Windows, not on macOS.
This is because file urls are different:
.replace('file:///', '')
D:/audio/sample.wav
file:///D:/audio/sample.wav
D:/audio/sample.wav
/Users/apple/sample.wav
file:///Users/apple/sample.wav
Users/apple/sample.wav
So, simply removing
file:///
is not portable across platforms.A portable solution is to use
urls()
method ofQMimeData
to get a list of file urls (QUrl
), iterate through the list and usetoLocalFile()
method to convert the URL to path string.