Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Commit

Permalink
Remove all non-secure calls from eplanning adapter (prebid#1179)
Browse files Browse the repository at this point in the history
  • Loading branch information
sebaperez authored Jan 31, 2020
1 parent 8e5a20c commit 481043b
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion adapters/eplanning/eplanning_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

func TestJsonSamples(t *testing.T) {
eplanningAdapter := NewEPlanningBidder(new(http.Client), "http://ads.us.e-planning.net/hb/1")
eplanningAdapter := NewEPlanningBidder(new(http.Client), "https://ads.us.e-planning.net/hb/1")
eplanningAdapter.testing = true
adapterstest.RunJSONBidderTest(t, "eplanningtest", eplanningAdapter)
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=300x250:300x250",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=300x250:300x250",
"body": {}
},
"mockResponse": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadun_itco_de:600x300&uid=2154987&ip=123.123.123.123",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadun_itco_de:600x300&uid=2154987&ip=123.123.123.123",
"body": {}
},
"mockResponse": {
Expand Down
4 changes: 2 additions & 2 deletions adapters/eplanning/eplanningtest/exemplary/two-banners.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300+300x250:300x250&ip=123.123.123.123",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300+300x250:300x250&ip=123.123.123.123",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -120,4 +120,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcodenosize:1x1",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcodenosize:1x1",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -67,4 +67,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand All @@ -45,4 +45,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -52,4 +52,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -55,4 +55,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -55,4 +55,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand All @@ -30,4 +30,4 @@
}
]
}


Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://ads.us.e-planning.net/hb/1/12345/1/www.publisher.com/ROS?r=pbs&ncb=1&ur=http%3A%2F%2Fwww.publisher.com%2Fawesome%2Fsite%3Fwith%3Dsome%26parameters%3Dhere&e=testadunitcode:600x300",
"uri": "https://ads.us.e-planning.net/hb/1/12345/1/www.publisher.com/ROS?r=pbs&ncb=1&ur=http%3A%2F%2Fwww.publisher.com%2Fawesome%2Fsite%3Fwith%3Dsome%26parameters%3Dhere&e=testadunitcode:600x300",
"body": {}
},
"mockResponse": {
Expand Down Expand Up @@ -73,4 +73,4 @@
}
]
}


2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ func SetupViper(v *viper.Viper, filename string) {
v.SetDefault("adapters.datablocks.endpoint", "http://{{.Host}}/openrtb2?sid={{.SourceId}}")
v.SetDefault("adapters.emx_digital.endpoint", "https://hb.emxdgt.com")
v.SetDefault("adapters.engagebdr.endpoint", "http://dsp.bnmla.com/hb")
v.SetDefault("adapters.eplanning.endpoint", "http://ads.us.e-planning.net/hb/1")
v.SetDefault("adapters.eplanning.endpoint", "https://ads.us.e-planning.net/hb/1")
v.SetDefault("adapters.gamma.endpoint", "https://hb.gammaplatform.com/adx/request/")
v.SetDefault("adapters.gamoshi.endpoint", "https://rtb.gamoshi.io")
v.SetDefault("adapters.grid.endpoint", "http://grid.bidswitch.net/sp_bid?sp=prebid")
Expand Down

0 comments on commit 481043b

Please sign in to comment.