job-list: support getting job project and bank #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
issue4697_4698_project_bank
branch
from
9a66c50
to
738e16a
Compare
chu11
changed the title
chu11
force-pushed
the
issue4697_4698_project_bank
branch
from
738e16a
to
c6848df
Compare
Problem: For systems that add project/bank accounting information in jobspecs, it would be convenient if users could look up that information via job-list / flux-jobs. Solution: Add support to job-list to get project/bank from a job. Fixes flux-framework#4697 Fixes flux-framework#4698
Problem: There is no coverage for getting project/bank information in job-list. Add coverage in t2260-job-list.t.
Problem: job-list now supports getting a job's project/bank, but flux-jobs does not support it. Support getting a job's project/bank via flux-jobs.
Problem: There is no coverage for the project/bank fields in flux-jobs. Add coverage in t2800-jobs-cmd.t.
Problem: The new project/bank fields in flux-jobs are not documented. Add them in flux-jobs(1).
chu11
force-pushed
the
issue4697_4698_project_bank
branch
from
c6848df
to
9340d86
Compare
Codecov Report
@@ Coverage Diff @@
## master #5413 +/- ##
==========================================
+ Coverage 83.59% 83.62% +0.02%
==========================================
Files 480 480
Lines 80782 80788 +6
==========================================
+ Hits 67533 67555 +22
+ Misses 13249 13233 -16
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
jobspec-updatesupport from #5408 and the upcomingflux updatesupport in #5409, this was half-easy to add so decided to add it (issues #4697 and #4698).This is dependent on #5409 going in of course.
It's worth noting that nothing in
flux-accountingdoes this yet, so it has no practical use. We may want to hold off on eventual merge untilflux-accountingmerging some stuff in for this.