Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python client #13

Merged
merged 19 commits into from
Nov 9, 2022
Merged

Add python client #13

merged 19 commits into from
Nov 9, 2022

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Nov 8, 2022

I very much borked the git history since I forgot to checkout from main (oops) but that's OK I can squash and merge (under my own low standards I suppose!) This will:

This will add a beautiful new Python client to be used with the API! I will also be making a Go one. Currently I'm just missing one more thing, a set of tests for the new client that mock the server (I'll work on this after I go for a run, it's going to get dark soon).

I also will need to update the docs generation to use the client instead of the (now non-existing) scripts, so those previous builds might fail here. It's no worries I'll get it all working when I get back! This has also been tested running with the API deployed with the Flux Operator, some screenshots included. <3

image

image

I'll make an exception this time since I maintain this repo, but I will be better in the future about not messing up the git history!

Okay going for a run!

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
I still need to write tests with a mock server and
add to run via a workflow

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Nov 9, 2022

It's going to work! So there is a bug in the current Python container with respect to cancel - we need to catch the Exception and then return a usable message to the user. This will be fixed when we rebuild the container, and then I'll re-enable the test. And from an actually updated branch this time... 😆

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch vsoch merged commit 8486ba8 into main Nov 9, 2022
@vsoch vsoch deleted the add/python-client branch November 9, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux job submit needs to support workdir and envars
1 participant