Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: make GitHub license detection happy #4

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

tgamblin
Copy link
Contributor

@tgamblin tgamblin commented Nov 4, 2022

The formatting on the current LGPL-3.0 license is throwing off GitHub's license detection for whatever reason.

  • Add a properly formatted LGPL-3.0 license so GitHub will report it properly.

The formatting on the current `LGPL-3.0` license is throwing off
GitHub's license detection for whatever reason.

- [x] Add a properly formatted `LGPL-3.0` license so GitHub will
      report it properly.
Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank you! I tried to grab it from here https://github.com/IQAndreas/markdown-licenses thinking that markdown would be right, but in retrospect I should have just copied the same file from flux-core. Let's get this merged and fixed!

@vsoch vsoch merged commit bb2da31 into flux-framework:main Nov 4, 2022
@vsoch
Copy link
Member

vsoch commented Nov 4, 2022

Nice!!

image

Look at Flux RESTful he's so sleepy... 😴

@tgamblin
Copy link
Contributor Author

tgamblin commented Nov 4, 2022

I usually grab from here because these are the actual files that GitHub's licensee tool compares to for similarity:

@vsoch
Copy link
Member

vsoch commented Nov 4, 2022

Oh thank you! I’ll search for choosealicense GitHub next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants