chore(deps): Update google.golang.org/grpc and golang.org/x/net #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
force-pushed
the
sec-update-grpc
branch
from
fb0c529 to
b42016d
Compare
yiannistri
reviewed
Oct 31, 2023
go.mod
Outdated
| @@ -205,7 +197,7 @@ replace ( | |||
| github.com/hashicorp/terraform-exec v0.16.1 => github.com/tf-controller/terraform-exec v0.15.1-0.20220809152546-4850a69faedb | |||
|
|
|||
| // Fix CVE-2023-32731 | |||
| google.golang.org/grpc => google.golang.org/grpc v1.53.0 | |||
| google.golang.org/grpc => google.golang.org/grpc v1.56.3 | |||
There was a problem hiding this comment.
I would move this out of the replace directive, as I don't understand why we need to pin this to an earlier version. Alternatively if we have to pin it to a specific version, I would update the comment above to indicate which CVE this addresses.
Reason: GHSA-m425-mq94-257g > Impact > > In affected releases of gRPC-Go, it is possible for an attacker to > send HTTP/2 requests, cancel them, and send subsequent requests, which > is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to > launch more concurrent method handlers than the configured maximum > stream limit. > > Patches > > This vulnerability was addressed by #6703 and has been included in > patch releases: 1.56.3, 1.57.1, 1.58.3. It is also included in the > latest release, 1.59.0. > > Along with applying the patch, users should also ensure they are using > the grpc.MaxConcurrentStreams server option to apply a limit to the > server's resources used for any single connection. > > Workarounds > > None. References: * GHSA-m425-mq94-257g * grpc/grpc-go#6703 Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yitsushi
force-pushed
the
sec-update-grpc
branch
from
b42016d to
17087f8
Compare
yiannistri
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: GHSA-m425-mq94-257g
References: