Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedString representation for VSCode extension #934

Merged
merged 15 commits into from
Dec 11, 2024
Merged

Conversation

ranjitjhala
Copy link
Contributor

Render trace using NestedString (a JSON representation) that lets the VSCode plugin display nested objects (e.g. struct with many fields) interactively

nested-vscode

@nilehmann any clue on how to avoid the pesky

warning: the feature `fmt_internals` is internal to the compiler or standard library
  --> crates/flux-middle/src/lib.rs:14:5
   |
14 |     fmt_internals
   |     ^^^^^^^^^^^^^
   |
   = note: using it is strongly discouraged
   = note: `#[warn(internal_features)]` on by default

which is needed in nested_with_bound_vars?

@nilehmann
Copy link
Member

nilehmann commented Dec 10, 2024

@ranjitjhala To deal with the internal features thing we can make fmt_bound_vars take an &mut impl fmt::Write instead of &mut fmt::Formatter<'_>. Both Formatter and String implement fmt::Write.

@ranjitjhala ranjitjhala merged commit f8e1b12 into main Dec 11, 2024
7 checks passed
@ranjitjhala ranjitjhala deleted the vscode-nested branch December 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants