Add null check for AssignedOrguPosition before assigning. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a null check of the AssignedOrguPosition before calling the findOrCreateAssignment function to prevent the creation of erroneous entries to "il_orgu_ua" with position_id = 0.
|
thanks for this! |
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a null check of the AssignedOrguPosition before calling the findOrCreateAssignment function to prevent the creation of erroneous entries to "il_orgu_ua" with position_id = 0 when AssignedOrguPosition is null.
This fix was created for a ILIAS 7 Installation that experienced a bug where UserDefaults created entries in the User-Org-Assignment table (il_orgu_ua) with position_id = 0, which does not exist. The reason for position 0 is the typecast in line 1555 to int, where null was typecast to 0 and inserted.