Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade charts to Flux v2.0.1 release #180

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

ravilr
Copy link
Contributor

@ravilr ravilr commented Jul 28, 2023

What this PR does / why we need it:

  • Upgrades the helm charts to use the Flux2 v2.0.1 release.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

Signed-off-by: ravilr <raviprasad_lr@yahoo.com>
@ravilr
Copy link
Contributor Author

ravilr commented Jul 28, 2023

@stefanprodan PTAL.

@@ -4,7 +4,6 @@ kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.12.0
creationTimestamp: null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this removal is a result of running make generate , not manual. Could be due to the kustomize version on my local workstation, which is:

$ kustomize version
{Version:kustomize/v4.5.2 GitCommit:9091919699baf1c5a5bf71b32ca73a993e98088b BuildDate:2022-02-09T23:19:28Z GoOs:darwin GoArch:arm64}

anyways, creationTimestamp: null was also removed from upstream : kubernetes-sigs/controller-tools#800 . so, this is good riddance here also..

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ravilr 🥇

@stefanprodan stefanprodan merged commit c544ff5 into fluxcd-community:main Jul 28, 2023
@ravilr ravilr deleted the release-2.0.1 branch July 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants