-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for New Relic Metrics Provider #614
Comments
I've never used New Relic but I'm open to reviewing a PR for this. Doing a quick Google search for NRQL go-client nothing come up so I don't know how would someone implement it. |
I did find something. https://github.com/newrelic/newrelic-client-go |
This looks ok to me https://github.com/newrelic/newrelic-client-go/blob/master/pkg/nrdb/example_query_test.go so it should be doable if a New Relic user wants to add this feature to Flagger. |
Sure, we are still in an evaluation phase with flagger within the organisation and if we are given the go-ahead to use Flagger then we will work on adding it. Thank you very much! |
@stefanprodan can you give me some tips of how this can be done? I'm willing to implement this feature. We use NR a lot, especially NewRelic Insights. |
@bernardoVale the NewRelic implementation should be similar to Datadog, please see https://github.com/weaveworks/flagger/blob/master/pkg/metrics/providers/datadog.go |
A have added New Relic as a metrics provider in the following pull request: #691 I still have to do manual testing but I wanted to get some initial feedback on whether the work is headed in the right direction. Thanks! |
Implemented in #691 |
Question
So i see that the current list of metric providers include Prometheus, Datadog and Cloudwatch. Is there a plan to add New Relic to that list? This is perhaps the only thing that is holding us back from using Flagger across the board.
Is there a plan to add support down the line?
The text was updated successfully, but these errors were encountered: