Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Relic as a metrics provider #691

Merged
merged 5 commits into from
Sep 17, 2020

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Sep 9, 2020

The pull requests adds New Relic as an available metrics provider. The implementation follows the one from the datadog provider.

@fpetkovski fpetkovski force-pushed the newrelic-provider branch 2 times, most recently from e3598c3 to ab28006 Compare September 9, 2020 10:06
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/metrics/providers/newrelic.go Outdated Show resolved Hide resolved
pkg/metrics/providers/newrelic.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept suggested changes

Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
@fpetkovski
Copy link
Contributor Author

@fpetkovski can you please add a "New Relic" section to the docs https://github.com/weaveworks/flagger/blob/master/docs/gitbook/usage/metrics.md

Thanks for the pointer, will add the section with the proposed queries and get back to you

docs/gitbook/usage/metrics.md Outdated Show resolved Hide resolved
docs/gitbook/usage/metrics.md Outdated Show resolved Hide resolved
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @fpetkovski 🥇

@stefanprodan stefanprodan merged commit fba16aa into fluxcd:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants