Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render inline promql query #1015

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Render inline promql query #1015

merged 1 commit into from
Sep 17, 2021

Conversation

somtochiama
Copy link
Member

Fixes #998

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1015 (3a2f688) into main (cfb68a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   56.85%   56.86%           
=======================================
  Files          75       75           
  Lines        6024     6025    +1     
=======================================
+ Hits         3425     3426    +1     
  Misses       2086     2086           
  Partials      513      513           
Impacted Files Coverage Δ
pkg/controller/scheduler_metrics.go 35.78% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb68a6...3a2f688. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌷

@stefanprodan stefanprodan merged commit b57d393 into fluxcd:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse error: missing unit character in duration\
3 participants