Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CanaryMetric.Threshold as omitempty #1047

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Nov 9, 2021

This is a deprecated field, so serializing it when it's unset doesn't look right.

My motivation for this change was slightly different: making this optional makes the the schema generated by cue get go work correctly.

Signed-off-by: Evan Cordell <cordell.evan@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ecordell

@stefanprodan stefanprodan merged commit 7f5a9ed into fluxcd:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants