Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the service toggle condition in the podinfo helm chart #1146

Merged

Conversation

canidam
Copy link
Contributor

@canidam canidam commented Mar 16, 2022

Create the service resource when it is enabled and canary is disabled

Fixes: #1002

Signed-off-by: Chen Anidam canidam@gmail.com

Signed-off-by: Chen Anidam <canidam@gmail.com>
@canidam canidam requested a review from stefanprodan as a code owner March 16, 2022 22:37
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @canidam

@stefanprodan stefanprodan changed the title Fix podinfo service toggle condition Fix the service toggle condition in the podinfo helm chart Mar 18, 2022
@stefanprodan stefanprodan merged commit cc7b35b into fluxcd:main Mar 18, 2022
@canidam canidam deleted the fix-podinfo-service-when-canary-enabled branch March 18, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug enable/disable in podinfo service.yaml
2 participants