fix: add finalizers to canaries

[vbelouso]

Hi,
I have an issue when using Flagger in OpenShift.
Installation command:

helm upgrade -i flagger flagger/flagger \
--namespace=istio-system \
--set crd.create=false \
--set meshProvider=istio \
--set metricsServer=http://prometheus:9090

After installation and creation test Canary I see an error message in Flagger pod.

{"level":"info","ts":"2022-06-14T10:01:23.876Z","caller":"controller/events.go:45",
"msg":"reconcileService failed: service catalog-canary.istioinaction create error: 
services \"catalog-canary\" is forbidden: cannot set blockOwnerDeletion if an ownerReference 
refers to a resource you can't set finalizers on: , <nil>","canary":"catalog-release.istioinaction"}

The error was fixed after adding the canaries/finalizers resource to the ClusterRole flagger.

Test environment:
OpenShift v4.8.39 (Kubernetes 1.21)
Flagger 1.21.0

Signed-off-by: Vladimir Belousov vbelouso@redhat.com

[stefanprodan]

Please add the RBAC entry to:

• https://github.com/fluxcd/flagger/blob/main/artifacts/flagger/account.yaml
• https://github.com/fluxcd/flagger/blob/main/kustomize/base/flagger/rbac.yaml

[vbelouso]

Please add the RBAC entry to:

• https://github.com/fluxcd/flagger/blob/main/artifacts/flagger/account.yaml
• https://github.com/fluxcd/flagger/blob/main/kustomize/base/flagger/rbac.yaml

Thanks for feedback

The final changes should be in the files you mentioned above or also in

• https://github.com/fluxcd/flagger/blob/main/charts/flagger/templates/rbac.yaml?

[stefanprodan]

Yes all 3 files must be kept in sync.

[stefanprodan]

Please squash both commits and add a sign-off

[stefanprodan]

LGTM

Thanks @vbelouso