-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile ClusterIP services and prep v0.10.0 #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanprodan
commented
Mar 26, 2019
•
edited
Loading
edited
- Reconcile ClusterIP services fix: Add more kubernetes routing tests for resource creation/updating #114
- Rename router sync to reconcile
- bump charts ver
- fix load tester chart and install command
- small docs improvements
errordeveloper
suggested changes
Mar 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing that is missing is link to https://docs.flagger.app/usage/appmesh-progressive-delivery
down the bottom, so it's clear "how do I verify it worked?".
@errordeveloper I've added the link to the App Mesh tutorial in the install docs. |
stefanprodan
changed the title
Prepare release v0.10.0
Reconcile ClusterIP services and prep v0.10.0
Mar 26, 2019
- add svc update tests fix: #114
stefanprodan
force-pushed
the
prep-0.10.0
branch
from
March 26, 2019 15:13
32d3bdf
to
3c6a2b1
Compare
errordeveloper
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.