Fix fallback logic for HPAv2 to v2beta2 #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage 54.73% 54.74%
=======================================
Files 81 81
Lines 6948 6949 +1
=======================================
+ Hits 3803 3804 +1
Misses 2550 2550
Partials 595 595
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Jul 29, 2022
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
force-pushed
the
fix-hpa-fallback
branch
from
844411c to
a5c284c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1238 (thanks @c19 for spotting and providing a fix)
Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works