Add app.kubernetes.io/version label to chart
#1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `app.kubernetes.io/version` label as described in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ This is useful if you have many deployments in different clusters and want to be able to monitor what versions you have deployed using something like `kube_pod_labels` from kube-state-metrics. Signed-off-by: Gustaf Lindstedt <gustaf.lindstedt@embark-studios.com>
|
@glindstedt I noticed from your commit sig that you work at Embark Studios? If Emabrk Studios uses Flagger, could you please add yourself as an adopter? That'd be really helpful for the project, thanks! :D |
|
@aryan9600 sure thing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
app.kubernetes.io/versionlabel as described in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/This is useful if you have many deployments in different clusters and want to be able to monitor what versions you have deployed using something like
kube_pod_labelsfrom kube-state-metrics.Signed-off-by: Gustaf Lindstedt gustaf.lindstedt@embark-studios.com