Support for overriding primary scaler replicas #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.24% // Head: 54.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
+ Coverage 54.24% 54.34% +0.10%
==========================================
Files 84 84
Lines 10016 10038 +22
==========================================
+ Hits 5433 5455 +22
Misses 3927 3927
Partials 656 656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
relu
force-pushed
the
autoscaler-replicas-overrides
branch
from
204ebea to
9963839
Compare
There was a problem hiding this comment.
Let's introduce here https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/how-it-works.md#canary-target a section for the autoscaler and explain its new behaviour.
stefanprodan
added
the
kind/enhancement
relu
force-pushed
the
autoscaler-replicas-overrides
branch
from
9963839 to
5e29dec
Compare
Adding support for overriding the primary scaler replica count via .spec.autoscalerRef.primaryScalerReplicas, a feature which would enable users to define a different scaling configurations for the primary. This can be useful in the situation where the user does not want to scale the canary workload to the exact same size as the primary, especially when opting for a canary deployment pattern where only a small portion of traffic is routed to the canary workload pods. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
force-pushed
the
autoscaler-replicas-overrides
branch
from
5e29dec to
5d3ab05
Compare
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for overriding the primary scaler replica count via .spec.autoscalerRef.primaryScalerReplicas, a feature that would enable users to define a different scaling configuration for the primary.
This can be useful in the situation where the user does not want to scale the canary workload to the exact same size as the primary, especially when opting for a canary deployment pattern where only a small portion of traffic is routed to the canary workload pods.