Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use regex to match against headers in istio #1364

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

aryan9600
Copy link
Member

Use regex filtering to match against session affinity cookie headers when using Istio instead of an exact match.

Fixes: #1339
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use regex filtering to match against session affinity cookie headers
when using Istio instead of an exact match.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 force-pushed the session-affinity-regex branch from a68a5c0 to 202b6e7 Compare February 8, 2023 16:11
@codecov-commenter
Copy link

Codecov Report

Base: 54.37% // Head: 54.42% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (202b6e7) compared to base (05d08d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   54.37%   54.42%   +0.05%     
==========================================
  Files          84       84              
  Lines       10044    10049       +5     
==========================================
+ Hits         5461     5469       +8     
+ Misses       3927     3925       -2     
+ Partials      656      655       -1     
Impacted Files Coverage Δ
pkg/controller/scheduler_metrics.go 37.64% <100.00%> (+0.74%) ⬆️
pkg/metrics/observers/render.go 62.50% <100.00%> (+18.75%) ⬆️
pkg/router/istio.go 76.98% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aryan9600 aryan9600 merged commit 317d53a into main Feb 8, 2023
@aryan9600 aryan9600 deleted the session-affinity-regex branch February 8, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary Release with Session Affinity doesn't work
3 participants