Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Allow configuring deployment annotations #1411

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Helm: Allow configuring deployment annotations #1411

merged 1 commit into from
Apr 12, 2023

Conversation

clux
Copy link
Contributor

@clux clux commented Apr 12, 2023

Currently this is not possible to do.

Follows the standard pattern (used by e.g. grafana (1,2)), which should fit in here given we already have podAnnotations.

@clux clux requested a review from stefanprodan as a code owner April 12, 2023 09:06
@stefanprodan stefanprodan changed the title Allow configuring deployment annotations Helm: Allow configuring deployment annotations Apr 12, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @clux

@aryan9600
Copy link
Member

@clux could you rebase on top of main?

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Contributor Author

clux commented Apr 12, 2023

Updated.

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @clux!

@aryan9600 aryan9600 merged commit 8708e35 into fluxcd:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants