Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec.suspend to allow suspending canary #1431

Merged
merged 1 commit into from
May 17, 2023
Merged

Add spec.suspend to allow suspending canary #1431

merged 1 commit into from
May 17, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented May 16, 2023

spec.suspend, if set to true will suspend the Canary, disabling any canary runs regardless of any changes to its target, services, etc. Note that if the Canary is suspended during an analysis, its paused until the Canary is unsuspended.

@aryan9600 aryan9600 requested a review from stefanprodan as a code owner May 16, 2023 12:59
@aryan9600 aryan9600 changed the title add spec.suspend to allow suspending canary Add spec.suspend to allow suspending canary May 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.07 🎉

Comparison is base (25754a3) 54.57% compared to head (aac74bd) 54.65%.

❗ Current head aac74bd differs from pull request most recent head 6384bfb. Consider uploading reports for the commit 6384bfb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
+ Coverage   54.57%   54.65%   +0.07%     
==========================================
  Files          84       84              
  Lines       10132    10120      -12     
==========================================
+ Hits         5530     5531       +1     
+ Misses       3947     3933      -14     
- Partials      655      656       +1     
Impacted Files Coverage Δ
pkg/controller/scheduler.go 45.22% <16.66%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aryan9600 aryan9600 changed the title Add spec.suspend to allow suspending canary Add spec.suspend to allow suspending canary May 17, 2023
Suspend, if set to true will suspend the Canary, disabling any canary runs
regardless of any changes to its target, services, etc. Note that if the
Canary is suspended during an analysis, its paused until the Canary is unsuspended.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600

@aryan9600 aryan9600 merged commit 5a6e2d1 into main May 17, 2023
@aryan9600 aryan9600 deleted the suspend branch May 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants