Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing namespace of HelmRepository in installation docs #1458

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fixing namespace of HelmRepository in installation docs #1458

merged 1 commit into from
Jul 13, 2023

Conversation

steve-fraser
Copy link
Contributor

@steve-fraser steve-fraser commented Jul 12, 2023

The documentation has the following config. The namespace of the HelmRepo is located in the flux-system and HelmRelease.spec.chart.sourceRef.Namespace is not configured

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: HelmRepository
metadata:
  name: flagger
  namespace: flux-system
spec:
  interval: 1h
  url: oci://ghcr.io/fluxcd/charts
  type: oci
---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: flagger
  namespace: flagger-system
spec:
  interval: 1h
  releaseName: flagger
  install: # override existing Flagger CRDs
    crds: CreateReplace
  upgrade: # update Flagger CRDs
    crds: CreateReplace
  chart:
    spec:
      chart: flagger
      version: 1.x # update Flagger to the latest minor version
      interval: 1m # scan for new versions every six hours
      sourceRef:
        kind: HelmRepository
        name: flagger
      verify: # verify the chart signature with Cosign keyless
        provider: cosign 
  values:
    nodeSelector:
      kubernetes.io/os: linux

Signed-off-by: Steven Fraser <steve.fraser@weave.works>
@steve-fraser steve-fraser changed the title Fixing namespace of HelmRepository Fixing namespace of HelmRepository in installation Docs Jul 12, 2023
@steve-fraser steve-fraser changed the title Fixing namespace of HelmRepository in installation Docs Fixing namespace of HelmRepository in installation docs Jul 12, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @steve-fraser

@stefanprodan stefanprodan merged commit ac3140b into fluxcd:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants