Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatewayapi: add support for b/g mirroring #1525

Merged
merged 2 commits into from
Oct 4, 2023
Merged

gatewayapi: add support for b/g mirroring #1525

merged 2 commits into from
Oct 4, 2023

Conversation

aryan9600
Copy link
Member

Add support for mirroring requests while performing B/G deployments with Gateway API. A RequestMirror filter pointing to the canary service is added to the HTTPRoute during a Canary run. During the Canary run, drift correction for .spec.rules[].filters is disabled to avoid removing the mirror filter.

@aryan9600 aryan9600 added the kind/enhancement Improvement request for an existing feature label Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (968a193) 54.96% compared to head (5a6b18a) 55.04%.
Report is 1 commits behind head on main.

❗ Current head 5a6b18a differs from pull request most recent head 8dbc72d. Consider uploading reports for the commit 8dbc72d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
+ Coverage   54.96%   55.04%   +0.07%     
==========================================
  Files          85       85              
  Lines       10325    10354      +29     
==========================================
+ Hits         5675     5699      +24     
- Misses       3988     3993       +5     
  Partials      662      662              
Files Coverage Δ
pkg/router/gateway_api_v1beta1.go 50.18% <82.75%> (+1.81%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document B/G mirroring in the Gateway API tutorial please

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🥇

Add support for mirroring requests while performing B/G deployments with
Gateway API. A `RequestMirror` filter pointing to the canary service is
added to the HTTPRoute during a Canary run. During the Canary run, drift
correction for `.spec.rules[].filters` is disabled to avoid removing the
mirror filter.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 merged commit 6112ad9 into main Oct 4, 2023
17 checks passed
@aryan9600 aryan9600 deleted the gw-mirror branch October 4, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants