return an error for missing metric templates #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he failure threshold Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
fix-metric-bug
branch
from
fea59a7 to
471da0a
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
+ Coverage 55.13% 55.19% +0.05%
==========================================
Files 85 85
Lines 10639 10643 +4
==========================================
+ Hits 5866 5874 +8
+ Misses 4104 4100 -4
Partials 669 669 ☔ View full report in Codecov by Sentry. |
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
Hi @stefanprodan, The PR is ready for review! |
|
@LiZhenCheng9527 will spend the next week reviewing Flagger PRs. This is top of my list. Thanks for you patience. |
stefanprodan
approved these changes
Jan 30, 2024
|
@LiZhenCheng9527 looks like this breaks a in-line queries, could you please see #1609 |
|
I will fix it as soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error for missing metric templates and count that towards the failure threshold.
fix #1581