Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where query with no metric template returned an error #1611

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

LiZhenCheng9527
Copy link
Contributor

Fix #1609

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527 LiZhenCheng9527 changed the title Fixed issue where query with no metric template returned an error Fixed bug where query with no metric template returned an error Mar 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (fb4af82) to head (b778013).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   56.64%   56.60%   -0.04%     
==========================================
  Files          85       85              
  Lines        8543     8549       +6     
==========================================
  Hits         4839     4839              
- Misses       3033     3038       +5     
- Partials      671      672       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @LiZhenCheng9527 for the quick fix 🥇

@stefanprodan stefanprodan merged commit 9a0f010 into fluxcd:main Mar 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errrs when using custom metrics without MetricTemplate
3 participants