-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to Kubernetes 1.30 #1638
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
===========================================
- Coverage 56.51% 34.10% -22.42%
===========================================
Files 85 282 +197
Lines 8571 20557 +11986
===========================================
+ Hits 4844 7011 +2167
- Misses 3053 12616 +9563
- Partials 674 930 +256 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @relu 🏅
Hey 👋 I believe this will trigger #1201 . We should warn somewhere that an upgrade will trigger a rollout of every canary. As a solution for the previous issue could we change the hash function so that it doesn't change during a lib upgrade? Thanks |
The serialisation seems to be same, otherwise the CI would fail in this PR. |
Can you point me to the test that is doing it for the deployment spec? I could not find it and doing local tests we did end up with differences using the lib for k8s 1.27 vs 1.30 |
There is one important addition from K8s 1.28 that could cause the above-mentioned issue: sidecar container support via the new |
I've updated the kind node version used in e2e tests. Pinned to v1.29.2 as that's the latest stable version available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks a lot @relu, i tried to get this done a couple of times but couldn't get it over the finish line, much obliged 🙇
@relu there is a new kind release that supports 1.30, please update the workflow to https://github.com/kubernetes-sigs/kind/releases/tag/v0.23.0 |
Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
Changes:
k8s.io/*
packages to v0.30.0.fmt
andtest-fmt
in Makefile to replace use ofgofmt
.k8s.io/code-generator
codegen scripts.