Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to Kubernetes 1.30 #1638

Merged
merged 2 commits into from
May 22, 2024
Merged

Update dependencies to Kubernetes 1.30 #1638

merged 2 commits into from
May 22, 2024

Conversation

relu
Copy link
Member

@relu relu commented May 2, 2024

Changes:

  • Update k8s.io/* packages to v0.30.0.
  • Update fmt and test-fmt in Makefile to replace use of gofmt.
  • Refactor code generation utility hack and replace deprecated k8s.io/code-generator codegen scripts.

@relu relu requested a review from stefanprodan as a code owner May 2, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.10%. Comparing base (e3a529e) to head (5e6815d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1638       +/-   ##
===========================================
- Coverage   56.51%   34.10%   -22.42%     
===========================================
  Files          85      282      +197     
  Lines        8571    20557    +11986     
===========================================
+ Hits         4844     7011     +2167     
- Misses       3053    12616     +9563     
- Partials      674      930      +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency file label May 2, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @relu 🏅

@joaosilva15
Copy link

Hey 👋 I believe this will trigger #1201 . We should warn somewhere that an upgrade will trigger a rollout of every canary.

As a solution for the previous issue could we change the hash function so that it doesn't change during a lib upgrade? Thanks

@stefanprodan
Copy link
Member

The serialisation seems to be same, otherwise the CI would fail in this PR.

@joaosilva15
Copy link

Can you point me to the test that is doing it for the deployment spec? I could not find it and doing local tests we did end up with differences using the lib for k8s 1.27 vs 1.30

@relu
Copy link
Member Author

relu commented May 6, 2024

There is one important addition from K8s 1.28 that could cause the above-mentioned issue: sidecar container support via the new .initContainers[].restartPolicy field. This is the reason that prompted me to submit the PR in the first place 😄

@relu
Copy link
Member Author

relu commented May 6, 2024

I've updated the kind node version used in e2e tests. Pinned to v1.29.2 as that's the latest stable version available.

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks a lot @relu, i tried to get this done a couple of times but couldn't get it over the finish line, much obliged 🙇

@stefanprodan
Copy link
Member

stefanprodan commented May 14, 2024

@relu there is a new kind release that supports 1.30, please update the workflow to https://github.com/kubernetes-sigs/kind/releases/tag/v0.23.0

Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants