fix(helm): podinfo fails to create the hpa object #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swimablefish
requested review from
stefanprodan and
aryan9600
as code owners
Signed-off-by: swimablefish <swimablefish@gmail.com>
stefanprodan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't use the podinfo helm chart to deploy. The HPA object need to be updated.
helm upgrade -i backend flagger/podinfo
--namespace default
--set nameOverride=backend
--set canary.enabled=true
W1111 15:09:04.768137 51420 warnings.go:70] unknown field "spec.metrics[0].resource.targetAverageUtilization"
W1111 15:09:04.768147 51420 warnings.go:70] unknown field "spec.metrics[1].resource.targetAverageValue"
Error: UPGRADE FAILED: failed to create resource: HorizontalPodAutoscaler.autoscaling "backend" is invalid: [spec.metrics[0].resource.target.type: Required value: must specify a metric target type, spec.metrics[0].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[0].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization, spec.metrics[1].resource.target.type: Required value: must specify a metric target type, spec.metrics[1].resource.target.type: Invalid value: "": must be either Utilization, Value, or AverageValue, spec.metrics[1].resource.target.averageUtilization: Required value: must set either a target raw value or a target utilization]