Automate zz_generated.deepcopy.go updates with make codegen #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahirokunn
changed the title
kahirokunn
changed the title
kahirokunn
force-pushed
the
add-helper-gen
branch
3 times, most recently
from
7efe552 to
f15d2b5
Compare
aryan9600
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
lgtm! thank you @kahirokunn 🙇
could you please squash this into one commit?
|
Okay. I will. |
chore(gatewayapi/v1beta1): add deepcopy-gen annotations run `make codegen` Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
add-helper-gen
branch
from
f15d2b5 to
febc327
Compare
|
@aryan9600 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
+ Coverage 35.08% 39.27% +4.18%
==========================================
Files 283 284 +1
Lines 24653 22379 -2274
==========================================
+ Hits 8650 8789 +139
+ Misses 15063 12643 -2420
- Partials 940 947 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
There was no provided method to update
zz_generated.deepcopy.go. As a result, updating related code required additional manual steps, increasing both effort and the potential for errors.Solution
This PR modifies the code generation process to allow updating
zz_generated.deepcopy.goby simply runningmake codegen. This automation streamlines the workflow, reducing manual intervention and improving developer efficiency.Changes
hack/update-codegen.shto include helper generation forzz_generated.deepcopy.go.make codegenhandles the generation process effectively.Benefits
zz_generated.deepcopy.go.