-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement confirm rollout gate, hook and API #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
means the canary rollout is paused (waiting for confirmation to proceed)
The confirm-rollout hooks are executed before the pre-rollout hooks. Flagger will halt the canary rollout until the confirm webhook returns HTTP status 200.
Closed
mumoshu
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for your effort
This is awesome @stefanprodan, thanks for all the work on this! |
POST /gate/[check|open|close]
stefanprodan
changed the title
Implement confirm rollout gate and hook
Implement confirm rollout gate, hook and API
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
confirm-rollout
webhook type. The confirmation hooks are executed before thepre-rollout
hooks. Flagger will halt the canary traffic shifting and analysis until the confirm webhook returns HTTP status 200.Manual gating:
The
/gate/halt
returns HTTP 403 thus blocking the rollout. If you have notifications enabled, Flagger will post a message to Slack or MS Teams if a canary rollout is waiting for approval.Change the URL to
/gate/approve
to start the canary analysis:Manual gating API:
Set the confirmation URL to
/gate/check
:By default the gate is closed, you can start or resume the canary rollout with:
Pause rollout:
curl -d '{"name": "podinfo","namespace":"test"}' http://localhost:8080/gate/close
Note that in order to tests this PR you have to update the Canary CRD and use the following images:
Fix: #163