Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadtester: add support for tillerless helm #280

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

vbehar
Copy link
Contributor

@vbehar vbehar commented Aug 21, 2019

  • upgrade helm to 2.14, and install the helm-tiller plugin to run in "tillerless" mode - with a local tiller instance
  • also add support to create RBAC resources in the loadtester chart, because when running in tillerless mode, the pod service account will be used instead of the tiller one - so we need to give him specific permissions

this allow the use of the loadtester to run helm test in tillerless mode, with helm tiller run -- helm test for example

- upgrade helm to 2.14, and install the [helm-tiller](https://github.com/rimusz/helm-tiller) plugin to run in "tillerless" mode - with a local tiller instance
- also add support to create RBAC resources in the loadtester chart, because when running in tillerless mode, the pod service account will be used instead of the tiller one - so we need to give him specific permissions

this allow the use of the loadtester to run `helm test` in tillerless mode, with `helm tiller run -- helm test` for example
@vbehar vbehar requested a review from stefanprodan as a code owner August 21, 2019 14:05
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @vbehar

@stefanprodan stefanprodan merged commit 5fc1baf into fluxcd:master Aug 21, 2019
@stefanprodan stefanprodan mentioned this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants