Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement confirm-promotion hook #307

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Implement confirm-promotion hook #307

merged 4 commits into from
Sep 23, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Sep 22, 2019

This PR implements the confirm-promotion webhook type for canaries, A/B testing and Blue/Green deployments. The confirm promotion hooks are executed right before the promotion step. The canary promotion is paused until the hooks return HTTP 200. While the promotion is paused, Flagger will continue to run the metrics checks and load tests. If you have notifications enabled, Flagger will post a message to Slack or MS Teams when a canary promotion is waiting for approval.

Example:

    webhooks:
      - name: "start analysis gate"
        type: confirm-rollout
        url: http://flagger-loadtester.test/gate/approve
      - name: "load testing"
        type: rollout
        url: http://flagger-loadtester.test/
        timeout: 5s
        metadata:
          cmd: "hey -z 1m -q 10 -c 2 http://podinfo-canary.test:9898/"
      - name: "promote gate"
        type: confirm-promotion
        url: http://flagger-loadtester.test/gate/approve

Fix: #299

Flagger image: weaveworks/flagger:confirm-promotion-8282f86

The confirm promotion hooks are executed right before the promotion step. The canary promotion is paused until the hooks return HTTP 200. While the promotion is paused, Flagger will continue to run the metrics checks and load tests.
@stefanprodan stefanprodan merged commit 9845578 into master Sep 23, 2019
@stefanprodan stefanprodan deleted the confirm-promotion branch September 23, 2019 09:32
@stefanprodan stefanprodan mentioned this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: confirm-abtest webhook
1 participant