-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track changes in ConfigMaps and Secrets #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scan target deployment volumes and containers for configmaps and secrets
- create primary configs and secrets at bootstrap - copy configs and secrets from canary to primary and update the pod spec on promotion
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 53.52% 56.75% +3.23%
==========================================
Files 8 9 +1
Lines 1035 1302 +267
==========================================
+ Hits 554 739 +185
- Misses 384 436 +52
- Partials 97 127 +30
Continue to review full report at Codecov.
|
- consolidate fake clients and mock objects
- restart analysis if a ConfigMap or Secret changes during rollout - add tests for tracked changes
stefanprodan
changed the title
Track ConfigMaps and Secrets
Track changes in ConfigMaps and Secrets
Jan 26, 2019
- generate a unique pod annotation on promotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tracking
ConfigMaps
andSecrets
referenced by a canary deployment:Fix: #36