Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor error handlings: oraganize messages, wrap with %w and use errors.Is #480

Merged
merged 11 commits into from
Mar 8, 2020

Conversation

mathetake
Copy link
Collaborator

No description provided.

@mathetake mathetake changed the title refactor error handlings: oraganize messages and wraps with %s refactor error handlings: oraganize messages and wraps with %w Mar 7, 2020
@mathetake mathetake force-pushed the refactor-error-handling branch from 9196e87 to 2ec24bb Compare March 7, 2020 15:18
@mathetake mathetake changed the title refactor error handlings: oraganize messages and wraps with %w refactor error handlings: oraganize messages, wrap with %w and use errors.Is Mar 8, 2020
@mathetake mathetake marked this pull request as ready for review March 8, 2020 05:04
@mathetake mathetake requested a review from stefanprodan as a code owner March 8, 2020 05:04
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Awesome refactoring! Thanks @mathetake

@mathetake mathetake merged commit ffbbc2c into master Mar 8, 2020
@mathetake mathetake deleted the refactor-error-handling branch March 8, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants