Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per-config configTracker disable via ConfigMap/Secret annotation #671

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

stealthybox
Copy link
Member

This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

This is the minimum implementation necessary to support the use-case of using the same db or apiKey
secret for a Canary target. This allows these Secret values to change without triggering a new
Canary analysis. One example where this is helpful is with systems that auto-provision and rotate
secrets. Note the secret manager needs to be able to configure and preserve the flagger specific
annotation.

Annotating a configmap/secret will affect all Canaries with targets referencing them the same way.
Per Canary and per Target API's were discussed but seemed excessive.
We could not think of many scenarios where you would want to enable config-tracking for a specific
config in one workload but disable it for that same exact config in another workload.
It is still possible to implement these per-workload API's on top of this simpler mechanism in the future.

Closes #435

@stealthybox stealthybox force-pushed the per-config-tracker-disable branch from 669c2d2 to fccdef3 Compare August 14, 2020 19:35
@stefanprodan
Copy link
Member

@stealthybox do we test if the disabled configs make in the primary deployment unchanged?

@stealthybox stealthybox force-pushed the per-config-tracker-disable branch from fccdef3 to 9ada1d3 Compare August 17, 2020 22:22
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy

Closes fluxcd#435
@stealthybox stealthybox force-pushed the per-config-tracker-disable branch from 9ada1d3 to dad70a6 Compare August 17, 2020 22:25
@stealthybox
Copy link
Member Author

@stefanprodan thanks for noticing -- this was bugging me in the back of my head for the past few days.
I think I got lazy last week because the test didn't already have any structure to loop through volumes, mounts, etc.

I just added the relevant positive and negative checks for primary Volumes.
I skipped VolumeMounts because a real apiserver should fail a template spec that doesn't have matching volume names. The mock client doesn't do this sort of validation, but I'm pretty sure our e2e tests that run on the CI kind clusters would.
What do you think?

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @stealthybox 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selective excluding secrets/configmaps from cloning
2 participants