Support per-config configTracker disable via ConfigMap/Secret annotation #671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a user to annotate a specific ConfigMap or Secret to be disabled/ignored via the
configTracking logic that tracks config changes makes configuration copies for the primary Deploy
This is the minimum implementation necessary to support the use-case of using the same db or apiKey
secret for a Canary target. This allows these Secret values to change without triggering a new
Canary analysis. One example where this is helpful is with systems that auto-provision and rotate
secrets. Note the secret manager needs to be able to configure and preserve the flagger specific
annotation.
Annotating a configmap/secret will affect all Canaries with targets referencing them the same way.
Per Canary and per Target API's were discussed but seemed excessive.
We could not think of many scenarios where you would want to enable config-tracking for a specific
config in one workload but disable it for that same exact config in another workload.
It is still possible to implement these per-workload API's on top of this simpler mechanism in the future.
Closes #435