Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fine-grained rbac for flagger helm #73

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

huydinhle
Copy link
Contributor

@huydinhle huydinhle commented Mar 5, 2019

@stefanprodan took a stab at this #48

I generated using audit2rbac and tested by running the tutorials to make sure no rbac problems showed up

Fix: #48

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files          13       13           
  Lines        1533     1533           
=======================================
  Hits          836      836           
  Misses        557      557           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c4d5a...2b6507d. Read the comment docs.

- list
- watch
- nonResourceURLs:
- /version?timeout=32s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the timeout arg? Would it work with /version only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, fixed

- ""
resources:
- services
verbs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need patch and update to cover future work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

- autoscaling
resources:
- horizontalpodautoscalers
verbs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need patch and update to cover future work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@stefanprodan
Copy link
Member

@huydinhle thanks for this. Please apply the same RBAC setting in here also https://github.com/stefanprodan/flagger/blob/master/artifacts/flagger/account.yaml

@huydinhle huydinhle force-pushed the fined-grained-rbac branch 2 times, most recently from 1b99f3f to 2b6507d Compare March 5, 2019 19:28
@huydinhle
Copy link
Contributor Author

addressed all the comments @stefanprodan

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huydinhle

@stefanprodan stefanprodan merged commit eda97f3 into fluxcd:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants