Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for VirtualService delegation when analysis is enabled #745

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Fix for VirtualService delegation when analysis is enabled #745

merged 4 commits into from
Dec 9, 2020

Conversation

Nerja
Copy link
Contributor

@Nerja Nerja commented Dec 8, 2020

Bugfix for delegate VirtualService with analysis enabled

@Nerja Nerja requested a review from stefanprodan as a code owner December 8, 2020 15:30
@stefanprodan
Copy link
Member

@Nerja I think it's best to remove skipAnalysis: true from e2e-istio-tests-delegate.sh I missed this when reviewing #715 sorry

@Nerja
Copy link
Contributor Author

Nerja commented Dec 8, 2020

Sounds good @stefanprodan, removed the new e2e test and adapted the old one.

stefanprodan
stefanprodan approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nerja

@stefanprodan stefanprodan changed the title Bugfix for delegate VirtualService with analysis enabled Fix for VirtualService delegation when analysis is enabled Dec 9, 2020
@stefanprodan stefanprodan merged commit bfb3331 into fluxcd:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nerja @stefanprodan @marcus-rodan-sinch